[AKS] az aks create/update: Use main cli for prometheus addon#8983
[AKS] az aks create/update: Use main cli for prometheus addon#8983yanzhudd merged 7 commits intoAzure:mainfrom
az aks create/update: Use main cli for prometheus addon#8983Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @bragi92, |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the AKS preview extension's Azure Monitor metrics functionality by migrating from custom implementation code to using the main Azure CLI infrastructure. The changes remove local azuremonitormetrics modules and update imports to use the main CLI's equivalent functionality.
- Removes entire azuremonitormetrics module implementation from aks-preview extension
- Updates imports to reference azure.cli.command_modules.acs.azuremonitormetrics instead of local modules
- Adds raw_parameters argument to rp_registrations function call to align with main CLI interface
Reviewed Changes
Copilot reviewed 17 out of 22 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| azuremonitorprofile.py | Updates imports to use main CLI modules and adds raw_parameters to rp_registrations call |
| Multiple module files | Complete removal of local azuremonitormetrics implementation files |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
|
Hi @bragi92 Release SuggestionsModule: aks-preview
Notes
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@bragi92, could you please help fix the failed CI checks? Please manually update the API version from 2025-05-01 to 2025-06-02-preview in the corresponding recording files or rerun the live test to generate new recording files.
|
|
@bragi92, could you please fix the failed CI checks? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
somehow the recording test could not pass, I would recommend you mark the tests as |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
yanzhudd
changed the title
az aks create\update: use main cli for prometheus addonaz aks create/update: Use main cli for prometheus addon
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create/update --enable-azure-monitor-metricsand related Azure Monitor metrics commandsGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.